split a testing_using_container script out of backend-for-testing.md #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Dec 1, 2023
testing_using_container.sh
Outdated
| # rename this if you test multiple things | ||
| CNAME=agama | ||
|
|
||
| test -f service/agama.gemspec || echo "You should run this from a checkout of agama" |
There was a problem hiding this comment.
maybe exit here if it is not run from checkout?
jreidinger
reviewed
Dec 1, 2023
| # because Agama pushes its limits so it's better | ||
| # to set up for easy testing | ||
| MORE_VOLUMES=() | ||
| if [ "${WITH_RUBY_DBUS-}" = 1 ]; then |
There was a problem hiding this comment.
Maybe document that env variable at the top of script together with some documentation what script does?
jreidinger
reviewed
Dec 1, 2023
testing_using_container.sh
Outdated
| # Manually start cockpit as socket activation does not work with port forwarding | ||
| ${CEXEC?} "systemctl start cockpit" | ||
|
|
||
| # Optional: Interactive shell in the container |
There was a problem hiding this comment.
good catch, that word is a leftover from the old file
jreidinger
approved these changes
Dec 1, 2023
Agama pushes the limits of ruby-dbus so often it is desirable to test against a WIP checkout of that library from ../ruby-dbus WITH_RUBY_DBUS=1 enables that
mvidner
force-pushed
the
testing-using-container
branch
from
7dd4bc4 to
b806f3b
Compare
Closed
Merged
imobachgs
added a commit
that referenced
this pull request
May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests: * #884 * #886 * #914 * #918 * #956 * #957 * #958 * #959 * #960 * #961 * #962 * #963 * #964 * #965 * #966 * #969 * #970 * #976 * #977 * #978 * #979 * #980 * #981 * #983 * #984 * #985 * #986 * #988 * #991 * #992 * #995 * #996 * #997 * #999 * #1003 * #1004 * #1006 * #1007 * #1008 * #1009 * #1010 * #1011 * #1012 * #1014 * #1015 * #1016 * #1017 * #1020 * #1022 * #1023 * #1024 * #1025 * #1027 * #1028 * #1029 * #1030 * #1031 * #1032 * #1033 * #1034 * #1035 * #1036 * #1038 * #1039 * #1041 * #1042 * #1043 * #1045 * #1046 * #1047 * #1048 * #1052 * #1054 * #1056 * #1057 * #1060 * #1061 * #1062 * #1063 * #1064 * #1066 * #1067 * #1068 * #1069 * #1071 * #1072 * #1073 * #1074 * #1075 * #1079 * #1080 * #1081 * #1082 * #1085 * #1086 * #1087 * #1088 * #1089 * #1090 * #1091 * #1092 * #1093 * #1094 * #1095 * #1096 * #1097 * #1098 * #1099 * #1100 * #1102 * #1103 * #1104 * #1105 * #1106 * #1109 * #1110 * #1111 * #1112 * #1114 * #1116 * #1117 * #1118 * #1119 * #1120 * #1121 * #1122 * #1123 * #1125 * #1126 * #1127 * #1128 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1135 * #1136 * #1138 * #1139 * #1140 * #1141 * #1142 * #1143 * #1144 * #1145 * #1146 * #1147 * #1148 * #1149 * #1151 * #1152 * #1153 * #1154 * #1155 * #1156 * #1157 * #1158 * #1160 * #1161 * #1162 * #1163 * #1164 * #1165 * #1166 * #1167 * #1168 * #1169 * #1170 * #1171 * #1172 * #1173 * #1174 * #1175 * #1177 * #1178 * #1180 * #1181 * #1182 * #1183 * #1184 * #1185 * #1187 * #1188 * #1189 * #1190 * #1191 * #1192 * #1193 * #1194 * #1195 * #1196 * #1198 * #1199 * #1200 * #1201 * #1203 * #1204 * #1205 * #1206 * #1207 * #1208 * #1209 * #1210 * #1211 * #1212 * #1213 * #1214 * #1215 * #1216 * #1217 * #1219 * #1220 * #1221 * #1222 * #1223 * #1224 * #1225 * #1226 * #1227 * #1229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have some documents
rust/agama-cli/doc/backend-for-testing.mddoc/testing_using_container.md(are they duplicate?)and a script
service/run_tests_in_container.shwhich is only enough forrake test:unitbut they either don't do what I want (below) or require cop-pasting
Solution
Make a script that I can use for testing the entire Agama frontend and backend, in a container
Testing
Screenshots
N/A